Update README.md for SEO - #8493
willsigsworth wants to merge 9 commits into
Conversation
docs: update README with code sample, SDK links, and What is Flagsmith section
|
@willsigsworth is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe README now describes Flagsmith’s product capabilities, deployment options, integrations, and supported application targets. It adds an interactive demo, updated quick-start instructions, JavaScript SDK usage, SDK listings, OpenFeature providers, community resources, hosted SaaS information, licensing details, and contribution links. Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🟡 Moderate · up to This README refresh improves onboarding and product guidance, but the JavaScript example needs correction before merge to avoid broken integrations or accidental exposure of a server-side key. Documentation-link, provider-list, grammar, and demo-markup fixes should also be applied. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 38236a5b-b98f-4d68-aaf1-f856973c1df4
📒 Files selected for processing (1)
README.md
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.
emyller
left a comment
There was a problem hiding this comment.
Looks great! Only a couple comments.
Co-authored-by: Matthew Elwell <mjelwell89@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: ec6eec28-2320-4f3f-90e8-1ee172c7fb57
📒 Files selected for processing (1)
README.md
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.
That's just how I was taught, but happy to remove Co-authored-by: Matthew Elwell <mjelwell89@gmail.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
59-59: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winUse the current JavaScript SDK package name.
The example imports the unscoped
flagsmithpackage. Update it to@flagsmith/flagsmithand addnpm install@flagsmith/flagsmith`` before the example. Otherwise, readers can encounter a module-resolution failure.Proposed correction
-import flagsmith from 'flagsmith'; +import flagsmith from '`@flagsmith/flagsmith`';Add
npm install@flagsmith/flagsmith`` before the example.
♻️ Duplicate comments (1)
README.md (1)
62-62: 🔒 Security & Privacy | 🛡️ Analyzed with Security Review | 🟠 MajorSensitive Data Exposure
Reachability: External
Exploitability: Moderate
CWE: CWE-200 — Exposure of Sensitive Information to an Unauthorized ActorIdentify the key as client-side.
This browser example uses
<your environment key>without stating the key type. If a reader inserts a server-side environment key, the browser exposes that secret to every user. Flagsmith documents client-side keys as public and server-side keys as secret. (docs.flagsmith.com)Change the placeholder to
<your client-side environment key>and add a warning that server-side keys must not be used in browser code.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: d55b6055-18d5-4744-92b5-fc3acf82ee63
📒 Files selected for processing (1)
README.md
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.
Added the list of providers through OpenFeature
Added "As an open-source solution, Flagsmith provides flexibility and greater control over your choices. Thanks to our partnership with OpenFeature, you are never locked into one vendor."
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 53d2da06-c26a-4190-b4ec-420485d064a9
📒 Files selected for processing (1)
README.md
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.
Added: "As this example runs in the browser, you should use your client-side environment key. Server-side keys must stay secret and never appear in browser code."
Took in coderabbit suggestions README.md#L71-L71: remove the trailing slash from the SDK overview URL. README.md#L77-L77: use https://docs.flagsmith.com/project-and-community/contributing. README.md#L91-L91: remove the trailing slash from the client-side SDK URL.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
38-38: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winClose the demo anchor.
The block opens an
<a>element at Line 36 but does not close it before</p>. Add</a>before</p>to prevent malformed HTML and inconsistent README rendering.Proposed fix
<a href="https://www.flagsmith.com/demo"> <img width="75%" height="75%" src="static-files/ReadMe_Demo.gif" alt="Try our interactive demo"> + </a> </p>
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: d2f066d6-2334-4206-ab9e-a7016365197d
📒 Files selected for processing (1)
README.md
Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review.
emyller
left a comment
There was a problem hiding this comment.
The changes look great, thank you! I've left a couple more comments. Also, for consistency, I'd like us to visit how we use the term "open-source", and standardise towards one form only: I see "Open source", "Open-Source", "open-source", etc.
- Updated opening "deployment" sentence - Fixed "open source" vs. "open-source" usage - Added link to the data model docs
emyller
left a comment
There was a problem hiding this comment.
This looks great, thanks @willsigsworth!
docs: update README with code sample, SDK links, and What is Flagsmith section
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to
Please describe.
How did you test this code?
Previewed the changes. There is no code that affects product
Please describe.
Optimizing the readme section of the repo for search.