feat: backend-oauth-consent-screen#7124
feat: backend-oauth-consent-screen#7124Zaimwa9 wants to merge 7 commits intofeat/implement-dynamic-client-registrationfrom
Conversation
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/implement-dynamic-client-registration #7124 +/- ##
============================================================================
Coverage 98.27% 98.28%
============================================================================
Files 1348 1349 +1
Lines 50350 50500 +150
============================================================================
+ Hits 49483 49633 +150
Misses 867 867 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
…om:Flagsmith/flagsmith into feat/oauth-consent-backend
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #7042
Adds a custom OAuth authorisation endpoint (
GET/POST /api/v1/oauth/authorize/) that replaces DOT's template basedAuthorizationViewwith a JSON API the frontend consent screen can call.GET /api/v1/oauth/authorize/Validates an OAuth authorisation request and returns application info:
{ "application": { "name": "My App", "client_id": "abc123" }, "scopes": { "mcp": "MCP access" }, "redirect_uri": "https://example.com/callback", "is_verified": false }POST /api/v1/oauth/authorize/Processes the user's consent decision and returns the redirect URI with an authorisation code (allow) or error=access_denied (deny):
{ "redirect_uri": "https://example.com/callback?code=...&state=..." }Implementation details
session-based internals.
validate_authorization_request can read them (DOT expects a form-based flow). This is documented with a
comment noting fragility on DOT upgrades.
custom view always shows the consent screen.
remain.
How did you test this code?
Manual end-to-end testing:
exchange