-
Notifications
You must be signed in to change notification settings - Fork 466
feat(API): Add make reset command for local development #6459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
emyller
wants to merge
7
commits into
main
Choose a base branch
from
feat/make-reset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+657
−2
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9467e47
Add `make reset` command for local development
emyller 41a49a9
Fix local environment defaults
emyller 5ab6637
Fix cookieSameSite reading wrong environment variable
emyller c05a9c5
Block `make reset` with a safety setting
emyller 1c11cc6
Fix segment and identity overrides in reset command
emyller 88898bc
Merge remote-tracking branch 'github/main' into feat/make-reset
emyller a45b8b8
Fix coverage
emyller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| DATABASE_URL=postgresql://postgres:password@localhost:5432/flagsmith | ||
| DJANGO_SETTINGS_MODULE=app.settings.local | ||
| PYTEST_ADDOPTS=--cov . --cov-report html -n auto | ||
| USE_SECURE_COOKIES=False | ||
| COOKIE_SAME_SITE=lax |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,3 +18,5 @@ | |
| ENABLE_ADMIN_ACCESS_USER_PASS = True | ||
|
|
||
| SKIP_MIGRATION_TESTS = True | ||
|
|
||
| ENABLE_LOCAL_DATABASE_RESET = True | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing testserver in ALLOWED_HOSTS for local settings
The
reset_local_databasecommand uses Django REST Framework'sAPIClientwhich makes requests withHost: testserver(Django's default for test clients). However,local.pyonly adds".ngrok.io","127.0.0.1", and"localhost"toALLOWED_HOSTS, not"testserver". SinceDEBUGdefaults toFalseincommon.pyand isn't overridden in.env-localorlocal.py, Django will validate the Host header and reject allAPIClientrequests with aDisallowedHostexception. The tests pass becausetest.pyboth setsDEBUG = Trueand adds"testserver"toALLOWED_HOSTS, but runningmake resetwith local settings will fail.