-
Notifications
You must be signed in to change notification settings - Fork 468
feat(frontend): add Jest unit testing infrastructure #6432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ef6d2cb to
0635372
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6432 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 1293 1293
Lines 46588 46588
=======================================
Hits 45696 45696
Misses 892 892 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Docker builds report
|
Zaimwa9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding a prop and to the deploy to production pipeline and should be good to go. Thanks for the initiative!
0876e33 to
0947abc
Compare
c6e25db to
f7f3e69
Compare
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 10. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
- Add Jest with ts-jest for TypeScript support - Add jest.config.js with path aliases matching tsconfig - Add npm scripts: test:unit, test:unit:watch, test:unit:coverage - Migrate format.js to format.ts for better Jest compatibility - Add unit tests for featureFilterParams utility Tests cover: - buildUrlParams: is_archived always explicitly set (never undefined) - buildApiFilterParams: is_archived always included in API params - getFiltersFromParams: URL param parsing - hasActiveFilters: filter state detection This prevents regression of the archived features bug where is_archived was undefined instead of explicitly 'false'. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Runs Jest unit tests on PRs that modify frontend/ files. Runs on all PRs including drafts (tests are fast and cheap). Lint and typecheck can be added later once those are cleaned up. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add 45 unit tests for Format utility pure functions - Remove unnecessary .toString() in countdown: parseInt(x.toString()) → Math.floor(x) - Remove unnecessary .toString() in shortenNumber: +parseFloat(x.toString()).toFixed(1) → +x.toFixed(1) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add explicit moment import to fix TypeScript UMD global error - Simplify money() to consistently return defaultValue for null/undefined/0 - Update tests to reflect new behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add clearMocks: true to Jest config for automatic mock cleanup - Add unit tests job to frontend-deploy-production.yml workflow - Update package-lock.json after rebase Addresses review comments from @Zaimwa9 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Address security warning from github-advanced-security bot by adding explicit permissions block with minimal `contents: read` scope. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
f7f3e69 to
076d406
Compare
Replace repetitive individual test cases with table-driven tests using Jest's it.each tagged template syntax. This improves test readability by grouping related test cases together and making input/output pairs easier to scan. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Zaimwa9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment and ready to be approved
| let result = str | ||
| for (let i = 0; i < Utils.accents.length; i++) { | ||
| str = str.replace(Utils.accents[i].letters, Utils.accents[i].base) | ||
| result = result.replace(Utils.accents[i].letters, Utils.accents[i].base) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm Utils is global and not breaking here ?
Summary
Add Jest unit testing infrastructure to the frontend codebase to enable fast, isolated unit tests alongside the existing TestCafe E2E tests.
Closes #6442
Changes
Jest Configuration
ts-jestpreset for TypeScript supportcommon/,components/,project/)common/andweb/directoriesCI/CD Integration
frontend-pull-request.yml)frontend-deploy-production.ymlInitial Test Coverage
featureFilterParamsutilitybuildUrlParams,buildApiFilterParams,getFiltersFromParams,hasActiveFiltersformatutilityshortenNumber,nearestTen,camelCase,enumeration,fullName,initialAndLastName,truncateText,ordinal,money,cssImage,trimAndHighlightSpaces,userDisplayNameformat.jsto TypeScript (format.ts) with proper type annotationsTest Style
it.eachwith tagged template literals for table-driven testsDependencies Added
jest,ts-jest,@types/jestHow did you test this code?
cd frontend npm run test:unitAll 102 tests pass.
Checklist
docs/if required so people know about the feature!