-
Couldn't load subscription status.
- Fork 457
chore: api type sync #6181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: api type sync #6181
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
for more information, see https://pre-commit.ci
Docker builds report
|
|
I understand and appreciate how this improves the developer experience for our FE engineers and contributors. My only issue with this, albeit a significant one, is that it undermines Flagsmith's "API-first" approach by causing the FE to completely ignore the OpenAPI schema. Currently, our schema is already unusable for code generation (#6183), and I'm afraid bypassing it for its main consumer, the Flagsmith UI, will cause it to deteriorate further, which goes against our long-term goals. While I appreciate the relatively quick gain introduced by this PR, I believe that investing in #6183 and relying on the currently available industry-standard codegen tools would benefit a wider audience of contributors and product users in the long run. |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Output of the Claude api sync, this validates the current RTK types against Flagsmith's API and builds a cache.
How did you test this code?