Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link to segment and identity override #5067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Jan 30, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Ref: #5009

Changes

  • Fix links to segment and identity overrides tab

How did you test this code?

Click on a segment override or identity override icon and check if the feature pane opens in the respective tab

links.mov

@tiagoapolo tiagoapolo self-assigned this Jan 30, 2025
@tiagoapolo tiagoapolo requested a review from a team as a code owner January 30, 2025 18:54
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team January 30, 2025 18:54
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 6:54pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 6:54pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 30, 2025 6:54pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5067 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5067 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5067 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5067 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5067 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5067 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Uffizzi Ephemeral Environment deployment-60477

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5067

📄 View Application Logs etc.

What is Uffizzi? Learn more!

this.editFeature(
projectFlag,
environmentFlags[id],
'segment-overrides',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that we had enums for these tab values now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants