Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): project permission migration unique error #5061

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

matthewelwell
Copy link
Contributor

Changes

The previous implementation of the migration was causing the unit tests to fail to run on my machine.

How did you test this code?

Ran the unit tests locally.

@matthewelwell matthewelwell requested a review from a team as a code owner January 30, 2025 15:42
@matthewelwell matthewelwell requested review from zachaysan and removed request for a team January 30, 2025 15:42
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 30, 2025 3:42pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jan 30, 2025 3:42pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jan 30, 2025 3:42pm

@github-actions github-actions bot added the api Issue related to the REST API label Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5061 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5061 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5061 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5061 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5061 Finished ✅ Results

@matthewelwell matthewelwell changed the title Fix project permission migration unique error fix(migrations): project permission migration unique error Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Uffizzi Preview deployment-60457 was deleted.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (b0d0a80) to head (554eb3a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5061   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files        1214     1214           
  Lines       42253    42253           
=======================================
  Hits        41169    41169           
  Misses       1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit ca943b8 into main Feb 4, 2025
37 checks passed
@matthewelwell matthewelwell deleted the fix/project-permissions-migration branch February 4, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants