fix: Force environments to be different names #5058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5058 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 1214 1214
Lines 42253 42264 +11
=======================================
+ Hits 41169 41180 +11
Misses 1084 1084 ☔ View full report in Codecov by Sentry. |
matthewelwell
requested changes
Jan 30, 2025
api/environments/views.py
Outdated
Comment on lines
143
to
148
| existing_environment = Environment.objects.filter( | ||
| name=serializer.validated_data["name"], | ||
| project=serializer.validated_data["project"], | ||
| ) | ||
| if existing_environment: | ||
| raise ValidationError("Existing environment for given name.") |
There was a problem hiding this comment.
I think we can do this in a much simpler way using the serializer as per the PR I linked on the issue (see here)
There was a problem hiding this comment.
Sorry I missed the linked PR! I've updated the code to handle this in a similar manner to what you posted.
matthewelwell
approved these changes
Jan 31, 2025
matthewelwell
deleted the
fix/force_environments_to_be_different_names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This forces new environments to have unique names. This was not intentionally done at the model level because some existing integrations rely on environment names and could break if they were updated to different names to solve existing conflicts.
How did you test this code?
One new test.