Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reusable copy to clipboard method and adds error handling #5010

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: reusable copy to clipboard method and adds error handling #5010

wants to merge 2 commits into from

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Jan 16, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Improves code consistency when using copy to clipboard method and removes redundant code.

How did you test this code?

  • Click on a feature and click on copy to clipboard to copy the feature name
  • Go to SDK Keys page and click on copy to clipboard to copy the SDK keys

@tiagoapolo tiagoapolo requested a review from a team as a code owner January 16, 2025 17:20
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team January 16, 2025 17:20
@tiagoapolo tiagoapolo self-assigned this Jan 16, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 3:35pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 3:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 3:35pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard chore labels Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5010 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5010 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5010 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5010 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5010 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5010 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Uffizzi Ephemeral Environment deployment-59990

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5010

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@github-actions github-actions bot added chore and removed chore labels Jan 16, 2025
@tiagoapolo tiagoapolo force-pushed the chore/unify-copy-clipboard-method branch from be4e81b to eadb3ae Compare January 17, 2025 15:32
@github-actions github-actions bot added chore and removed chore labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

At least 1 approving review is required to merge this pull request.

Assignees

@tiagoapolo tiagoapolo

Labels
chore front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tiagoapolo