-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Speed up identity overrides #4840
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Docker builds report
|
Uffizzi Ephemeral Environment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a bunch of questions + not sure if the original issue is actually solved by this.
…h/flagsmith into fix/speed_up_identity_overrides
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4840 +/- ##
========================================
Coverage 97.38% 97.38%
========================================
Files 1189 1189
Lines 41420 41531 +111
========================================
+ Hits 40338 40447 +109
- Misses 1082 1084 +2 ☔ View full report in Codecov by Sentry. |
Changes
This changes the way that identity overrides are requested for the features page in two ways. First, instead of the entire document getting paginated and returned to the client, only one page per feature is returned. Second, instead of every feature being returned in the network call, we only serve up the features for the current page.
How did you test this code?
I've written one new test, although I'm awaiting codecov to let me know where else needs testing, since I'm sure some are missing.