Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add .Net caching to docs #3839

Closed
wants to merge 5 commits into from

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add content about .Net caching to docs

How did you test this code?

Tested locally running docusaurus

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 10:04am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 10:04am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 10:04am

docs/docs/clients/server-side.md Outdated Show resolved Hide resolved
docs/docs/clients/server-side.md Outdated Show resolved Hide resolved
docs/docs/clients/server-side.md Outdated Show resolved Hide resolved
@matthewelwell
Copy link
Contributor

matthewelwell commented Apr 25, 2024

I actually don't think the .NET caching implementation is usable in it's current state since it doesn't implement any method for maintaining the size. This will likely cause a memory leak in any of our customer's applications that utilise the caching and have a large number of identities. See issue here.

@novakzaballa
Copy link
Contributor Author

I agree, we also should allow the user to set the TTL.

@novakzaballa novakzaballa marked this pull request as draft April 29, 2024 20:19
auto-merge was automatically disabled April 29, 2024 20:19

Pull request was converted to draft

@novakzaballa
Copy link
Contributor Author

As per the conversation, this docs PR will be closed until the feature is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants