feat: Add offline mode for using the client locally #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This responds to the Ruby section of this issue which provides a way for various Flagsmith SDKs to operate in offline mode via using a static JSON document that gan be bundled with the SDK itself. I tried to follow the Python implementation as a guide, but since the structure of the Ruby client is different some approaches were not as clean.
Also, there is a minor upgrade to the project to improve our debugger as well.
Testing & Investigation
Because the Ruby SDK is a large piece of work, I wasn't able to fully verify that every method was covered. But I was able to verify that the environment document loaded correctly and since local evaluation mode relies upon a local document, most of the testing and investigation was trying to understand and verify that offline mode can work through the Flagsmith client.