Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps): loosen flagsmith-flag-engine constraints #68

Closed
wants to merge 1 commit into from
Closed

feat(deps): loosen flagsmith-flag-engine constraints #68

wants to merge 1 commit into from

Conversation

lukapeschke
Copy link

This allows to use flagsmith with flagsmiht-flag-engine >=5.0.0 as well, which would allow to use pydantic >=2.0

partially closes #55

@lukapeschke
feat(deps): loosen flagsmith-flag-engine constraints
397e669 
This allows to use flagsmith with flagsmiht-flag-engine >=5.0.0 as well, which would allow to use pydantic >=2.0

partially closes #55

Signed-off-by: Luka Peschke <[email protected]>
@lukapeschke
Copy link
Author

Hello @matthewelwell since flagsmith-flag-engine 5.0.0 has been released, it should be possible to use the flagsmith python client with pydantic v2, right ? I could not see a breaking change apart from the pydantic upgrade in the changelog, so I guessed allowing both 4.x and 5.x versions here would be fine, and users would still be able to pick between pydantic 1 and 2.

A review would be welcome 😄 if something is missing from this PR, please let me know!

@PrettyWood PrettyWood mentioned this pull request Nov 22, 2023
Closed
@matthewelwell
Copy link
Contributor

Based on the changes necessary as per #69 , I'm not convinced this PR will work as expected. It will still not be possible to use flagsmith-flag-engine>=5. I'm going to close this for now but we are looking to merge in #69 very soon and it will be included in 3.5.0.

@lukapeschke
Copy link
Author

All right, thanks for the heads up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use pydantic 2
2 participants
@lukapeschke @matthewelwell