test: Local evaluation testing #108
Conversation
There was a problem hiding this comment.
I've reviewed this. It all looks ok to me and seems to check mostly the right things, the main issue (as per my comment) is that we're not checking that the values are the same before and after the migration (which I think we should expect?).
I'd say that we should implement some way to verify this, it could just be a local json file or something, or a pickled python object written to a file maybe?
tests/test_local_eval.py
Outdated
| return _get_flag_mock( | ||
| value=get_matching_str( | ||
| "environment default", | ||
| 'overridden by "split_segment"', |
There was a problem hiding this comment.
If we can, I'd like to be more specific here. Whether the identity belongs to the percentage split segment shouldn't change before and after migration. I think this is going to mean that we're just checking that it takes one of the 2 possible values.
There was a problem hiding this comment.
Switched to static values.
khvn26
force-pushed
the
test/test-local-eval
branch
from
9e1508c to
e11c727
Compare
DO NOT MERGE. This contains an automated SDK test for Edge V2 migration.
To run, clone, then:
After the migration, run: