feat: new javascript example v2 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove single quotes, it is not a string Co-authored-by: Matthew Elwell <[email protected]>
|
Hey, @matthewelwell! Do i need to modify or add anything else here? |
|
I'd really love to standardise all of the JS examples with shared markup, CSS, content and demonstation. Perhaps what I'll do is use some of this PR as inspiration. Thanks very much for this |
If this one was approved, I was thinking about gradually doing for the others JS Examples in my spare time. If you wanted, of course. But anyway, glad it helped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New example more friendly to newbies.
@gnumoreno