Repository navigation
feat: Implement SDK spec v0.7.0 - #107
Closed
flagsmithsmith[bot] wants to merge 5 commits into
Closed
flagsmithsmith[bot] wants to merge 5 commits into
flagsmithsmith[bot] wants to merge 5 commits into
Conversation
The flag analytics timer left the error of a failed send unhandled, so a network failure or an error response from Flagsmith crashed the app with an uncaught exception. The timer now drops the error, which syncAnalyticsData has already logged, and resends on the next tick. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 36a294b)
An exposure recorded by getExperimentFlag now carries the traits the identity was evaluated with, as the other Flagsmith SDKs do, so that experiment results can be analysed by trait. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit b5f536a)
Wires the spec's new steps to the SDK's event tracking: creating a client with events enabled, getExperimentFlag, trackEvent and trackExposureEvent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 180ac98)
…elay A fixed 100 ms wait could see fewer scheduled sends than expected. The test now waits for the second failed send, which also ensures the first failure has been handled before the test ends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit d76c743)
1 task
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Contributor
Author
|
Superseded by #109, which carries this pull request's implementation work, for the SDK spec's latest version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the SDK spec's v0.7.0 in this SDK.
This pull request was opened by an AI agent (OpenHands).