feat: Identity overrides in local evaluation mode #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
requested review from
a team and
gagantrivedi
and removed request for
a team
khvn26
force-pushed
the
feat/identities-in-local-eval
branch
from
2d7b95d to
2bcbf2c
Compare
- Rename `Identity.flags` to `Identity.identity_features` - Store identity overrides by identifier - Use stored identities when evaluating identity flags - Use a JSON file fixture for tests
khvn26
force-pushed
the
feat/identities-in-local-eval
branch
from
239aec5 to
e9be609
Compare
gagantrivedi
reviewed
Apr 8, 2024
| @@ -12,7 +12,7 @@ defmodule Flagsmith.Schemas.Identity do | |||
| field(:django_id, :integer) | |||
| field(:identifier, :string) | |||
| field(:environment_key, :string) | |||
| embeds_many(:flags, Flagsmith.Schemas.Features.FeatureState) | |||
There was a problem hiding this comment.
Is this a public attribute (if such a thing exists in Elixir)? If so, should we increment its major version?
There was a problem hiding this comment.
It's not private, but the model itself is not meant to be used directly.
gagantrivedi
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to Flagsmith/flagsmith#3132.
Environment.identity_overrides, remove integrations config attributesIdentity.flagstoIdentity.identity_features