Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
/charts/flagsmith/Chart.yaml
in the sectionversion
or I'm merging to arelease branch
Changes
Fixes issues with special characters in database passwords when using pgbouncer. The fix should be backwards compatible as well. Introduces the option to specify 'passwordOverride' needed because of the issue described here : #163
How did you test this code?
Manually :
You can go to the chart folder and do :
helm template flagsmith --set pgbouncer.enabled=true --set databaseExternal.enabled=true --set databaseExternal.host=test --set databaseExternal.username=test --set databaseExternal.database=test --set databaseExternal.password=test --set=pgbouncer.passwordOverride='test%!asd' --output-dir ./output --debug
- This should override the test password.helm template flagsmith --set pgbouncer.enabled=true --set databaseExternal.enabled=true --set databaseExternal.host=test --set databaseExternal.username=test --set databaseExternal.database=test --set databaseExternal.password=test --output-dir ./output --debug
Closes #163