Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pgbouncer password override #314

Conversation

KonstantinPetkov96
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • [ X ] I have filled in the "Changes" section below?
  • [ X ] I have filled in the "How did you test this code" section below?
  • [ X ] I have bumped the version number in /charts/flagsmith/Chart.yaml in the section version or I'm merging to a
    release branch

Changes

Fixes issues with special characters in database passwords when using pgbouncer. The fix should be backwards compatible as well. Introduces the option to specify 'passwordOverride' needed because of the issue described here : #163

How did you test this code?

Manually :
You can go to the chart folder and do :

  1. helm template flagsmith --set pgbouncer.enabled=true --set databaseExternal.enabled=true --set databaseExternal.host=test --set databaseExternal.username=test --set databaseExternal.database=test --set databaseExternal.password=test --set=pgbouncer.passwordOverride='test%!asd' --output-dir ./output --debug - This should override the test password.
  2. And you can also verify that the code works without the password override using : helm template flagsmith --set pgbouncer.enabled=true --set databaseExternal.enabled=true --set databaseExternal.host=test --set databaseExternal.username=test --set databaseExternal.database=test --set databaseExternal.password=test --output-dir ./output --debug
  3. Look at each output in the output folder.

Closes #163

@KonstantinPetkov96 KonstantinPetkov96 requested a review from a team as a code owner February 2, 2025 20:22
@KonstantinPetkov96 KonstantinPetkov96 requested review from matthewelwell and removed request for a team February 2, 2025 20:22
@matthewelwell matthewelwell merged commit 45be7b3 into Flagsmith:main Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect PGBOUNCER secret password parsing
3 participants