add a cpp extension #380
Open
add a cpp extension #380
+48
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Galaxy1458
reviewed
Dec 30, 2024
setup.py
Outdated
| if debug_mode: | ||
| print("Compiling in debug mode") | ||
|
|
||
| use_cuda = use_cuda and torch.cuda.is_available() and CUDA_HOME is not None |
There was a problem hiding this comment.
Expect using torch_device_fn.is_available() instead of torch.cuda.is_available()
and torch_device_fn from（from ..runtime import torch_device_fn）
There was a problem hiding this comment.
Since it is a part of flag_gems, it may not use the utilities provided by flag_gems. So I removed cuda extensions since it is planned to use c++-only extensions here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Other
Type of Change
Other
Description
Add a cpp extension(flag_gems._C) to flag_gems.
It finds torch include dirs & libraries and also cuda include dirs & libraries(if necessary).
Issue
Progress
Performance