add inplace pointwise operators #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclementine
force-pushed
the
inplace_pointwise
branch
from
59f04ce to
8795e7a
Compare
…ark_dirty); add tests for inplace unary pointwise operations
|
I have to solve the problem at when the output has in-appropriate dtype or shape it does not raise error. |
Bowen12992
reviewed
Sep 25, 2024
| @@ -37,4 +37,16 @@ def add(A, B, *, alpha=1): | |||
| elif isinstance(B, torch.Tensor): | |||
| return add_func_scalar_tensor(A, B, alpha) | |||
| else: | |||
| return A + B * alpha | |||
| return torch.tensor(A + B * alpha) | |||
There was a problem hiding this comment.
torch returns a tensor for that case.
Bowen12992
reviewed
Sep 25, 2024
| @@ -32,6 +32,21 @@ def test_accuracy_abs(shape, dtype): | |||
| gems_assert_equal(res_out, ref_out) | |||
|
|
|||
|
|
|||
| @pytest.mark.inplace | |||
There was a problem hiding this comment.
what is inplace mark used for? can we merge abs_ test into abs test?
Bowen12992
previously approved these changes
Sep 25, 2024
It'll add a lot of redundancy if we include all the variants. Shall we do that later? |
|
It's probably a good time to update this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
New Feature
Description
Add inplace pointwise operators.
Issue
Progress
Performance