Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Streamline Bikelane Categories #146

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Streamline Bikelane Categories #146

merged 6 commits into from
Jul 2, 2024

Conversation

rush42
Copy link
Contributor

@rush42 rush42 commented Jun 28, 2024 •
edited
Loading

TODO:

  • add test for wrapper
  • unify categorization of infrastructure and only data categories

@rush42 rush42 requested a review from tordans July 1, 2024 12:08
tordans
tordans reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht sehr gut aus. Habe im Code kommentiert.
Ich gehe davon aus, dass der Diff-Check clean ist?…
Was mir allgemein noch fehlt sind Softwaretests. Zumindest mal ein, zwei die das Setup grob testen.

processing/topics/roads_bikelanes/bikelanes/BikelaneCategories.lua Outdated Show resolved Hide resolved
processing/topics/roads_bikelanes/bikelanes/BikelaneCategories.lua Outdated Show resolved Hide resolved
processing/topics/roads_bikelanes/bikelanes/BikelaneCategories.lua Outdated Show resolved Hide resolved
processing/topics/roads_bikelanes/bikelanes/BikelaneCategories.lua Show resolved Hide resolved
processing/topics/roads_bikelanes/bikelanes/BikelaneCategories.lua Outdated Show resolved Hide resolved
processing/topics/roads_bikelanes/bikelanes/BikelaneCategories.lua Outdated Show resolved Hide resolved
processing/topics/roads_bikelanes/bikelanes/BikelaneCategories.lua Outdated Show resolved Hide resolved
processing/topics/roads_bikelanes/bikelanes/BikelaneCategories.lua Show resolved Hide resolved
processing/topics/roads_bikelanes/bikelanes/BikelaneCategories.lua Show resolved Hide resolved
processing/topics/roads_bikelanes/bikelanes/BikelaneCategories.lua Show resolved Hide resolved
@tordans tordans changed the title WIP: Streamline Bikelane Categories Streamline Bikelane Categories Jul 1, 2024
@rush42 rush42 force-pushed the streamline_bikelanescategories branch 6 times, most recently from 3821f7e to 6bf27c3 Compare July 2, 2024 09:08
@rush42 rush42 force-pushed the streamline_bikelanescategories branch from 6bf27c3 to 3c8922b Compare July 2, 2024 09:24
@rush42 rush42 merged commit 96ccdda into develop Jul 2, 2024
1 check passed
@rush42 rush42 deleted the streamline_bikelanescategories branch July 2, 2024 09:26
rush42 added a commit to FixMyBerlin/atlas-app that referenced this pull request Jul 15, 2024
@rush42
Streamline Bikelane Categories (FixMyBerlin/atlas-geo#146)
846618e
rush42 added a commit to FixMyBerlin/atlas-app that referenced this pull request Jul 15, 2024
@rush42
Streamline Bikelane Categories (FixMyBerlin/atlas-geo#146)
fb07bb3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tordans tordans tordans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rush42 @tordans