A11y/improvements sep 24 #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ostafinskim , Is there a link to the Zoonou tasks? And are these changes on the staging site? |
sean-dunwoody
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Hi @ostafinskim ,
Thanks for your work on this.
I can't see any obvious code problems in the PR so I'm approving this for you.
Please bear in mind that I don't have knowledge of why these fixes were made, so it's possible some of the accessibility issues might not be 100% resolved - presumably Zoonou will do a re-test soon though, so that should hopefully flag up any potential mistakes.
Assuming this has been tested on the staging site then I don't see any reason why it can't be deployed to production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These improvements are based on feedback we're received form Zoonou