Introduce new related_documents field to directus for exhibition file… #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-dunwoody
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Hi @JamieC24 , thanks for your work on this. Admittedly I'm not that familiar with the background here, and precisely how this fixes the issue, but assuming you've tested this on staging then I'm happy to approve this change. It looks ok to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s to live
This work is a solution to ticket #14475 on Zendesk and adds support for a new field named "Related Documents" and does the following:
Changes the empty check in
exhibitions/templates/details-2024.blade.phpfrom$exhibition['exhibition_files']to$exhibition['related_documents']so that therelated_documentsfield is only used by the new templateIntroduces the
$sourcevariable that's initialised and given a default value in theexhibitions/files.blade.phpfile and passed a custom value in the@includeindetails-2024.blade.phpto simplify the template code.This work has been deployed to staging and approved by the client for deployment to production.