Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

related events date field #687

Closed
wants to merge 2 commits into from

Conversation

ostafinskim
Copy link
Contributor

@ostafinskim ostafinskim commented Jun 17, 2024

@@ -44,6 +44,9 @@
<div class="related-event-wrapper">
@if(!empty($event['heading']))
<h4 class="cta-title">{{ $event['heading'] }}</h4>
@if(!empty($event['event_date']))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally recommend moving this outside of the @if(!empty($event['heading'])) loop (e.g. there may be no heading but there might be an event date), but this is a really minor thing and probably won't cause any problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I get this template updated.

@ostafinskim ostafinskim force-pushed the hotfix/14432-related-events-date branch 2 times, most recently from bdc0852 to c292fae Compare June 18, 2024 10:09
@ostafinskim ostafinskim deleted the hotfix/14432-related-events-date branch June 18, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants