-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/homepage rows email subscriber #619
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portableant
reviewed
Sep 29, 2023
sean-dunwoody
previously requested changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ostafinskim ,
Looks good to me, just one question from me.
If you could please action the note from Dan (about the SVG icon), then happy to approve this for you so it can be merged and deployed.
Thanks
AlanJIsaacson
approved these changes
Oct 5, 2023
AlanJIsaacson
approved these changes
Oct 5, 2023
AlanJIsaacson
dismissed
sean-dunwoody’s stale review
October 5, 2023 09:21
No font awesome icon available to match design
We previously used fa-envelope with white fill/path depending on use case.
D
From: Miro Ostafinski ***@***.***>
Date: Thursday, 5 October 2023 at 09:26
To: FitzwilliamMuseum/fitz-main-website ***@***.***>
Cc: Daniel Pett ***@***.***>, Comment ***@***.***>
Subject: Re: [FitzwilliamMuseum/fitz-main-website] Feat/homepage rows email subscriber (PR #619)
@ostafinskim commented on this pull request.
________________________________
In resources/views/exhibitions/index.blade.php<#619 (comment)>:
@@ -14,9 +14,8 @@
@section('current')
<div class="container-fluid py-3 bg-gdbo">
<div class="container">
- @if(!empty($current['data']))
-
- <h3>Our current exhibitions</h3>
+ @if(!empty($current['data']) && !empty($displays['data']))
Unfortunately I couldn't find free fontawesome svg that matches to current desing icon.
—
Reply to this email directly, view it on GitHub<#619 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACF6WCD2T75V2XG3YI5BELX5ZVLZAVCNFSM6AAAAAA5LDXYBOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJZGIYDGMZUGA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.