Added validation for the context of extensions #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Firely.Fhir.Validation/Impl/FhirPathValidator.cs # test/Firely.Fhir.Validation.Compilation.Tests.Shared/FhirTestCases
|
We have an issue here (Apart from the fact that I seem to have done something weird with the subrepo). We do not step into every profile we encounter. This makes sense for some cases, except it makes verifying whether we are in the correct Element a lot harder, and as a bonus, I believe omitting it is a wrong assumption. In a separate branch, I created a Patient with a link (backboneElement) with multiple id's and, lo and behold, the validation is a success! I believe us not invoking the profile of backboneElement is a mistake here. This would require quite a big change to the validator though, but it would make my work a LOT easier. I will leave this branch for now until we have discussed this internally. |
# Conflicts: # test/Firely.Fhir.Validation.Compilation.Tests.Shared/FhirTestCases
…tension-Context.Resource
ewoutkramer
requested changes
Oct 2, 2024
.idea/.idea.Firely.Validator.API/.idea/projectSettingsUpdater.xml
Outdated
Show resolved
Hide resolved
src/Firely.Fhir.Validation.Compilation.Shared/SchemaBuilders/ExtensionContextBuilder.cs
Show resolved
Hide resolved
src/Firely.Fhir.Validation.Compilation.Shared/SchemaBuilders/TypeReferenceBuilder.cs
Outdated
Show resolved
Hide resolved
…t was inconsistent. Also updated manifest.
ewoutkramer
requested changes
Oct 14, 2024
Since BaseType needs to be serializable, I had to add [DataMember] to its only property.
ewoutkramer
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The validator should now (finally) validate extension contexts against their expected context.
Related issues
Closes #267
Tests
Added tests for all possible extension contexts