Skip to content

20190318 Community Meeting Minutes

Ewout Kramer edited this page Apr 30, 2024 · 1 revision

Time: 10:00-11:00 UTC (11:00-12:00 CET, 05:00-06:00 EST, 21:00-22:00 AEDT) Location: Join Zoom Meeting https://zoom.us/j/573322038

API work

  • Have been working on performance improvements for 1.2-beta2/3/4/5
  • Also on bug fixes for 1.1, PRs are ready to be pulled
  • Still to do: Merge them to STU3/R4 and 1.2 (DSTU2/STU3/R4)
  • In the API the unit test projects where all netcoreapp2.1, but those cannot be profiled with the Visual Studio unit test profiles, so will slowly move them back to use .NET Framework 4.7.2.

Sunsetting DSTU2

  • Are we happy to take DSTU2 into "hotfix only" state?
  • BP: Are we talking about making 1.2 the last one for DSTU2?
  • EK: Yes, or even wait until 2.x - we're not in a hurry.
  • Rationale: there is a notable cost for maintaining it, and how much value is there still? The basics work, it has been around for quite some time.
  • Discuss again during the US call.

Common Code Project

  • Finalized the code for detecting used FHIR versions
  • The analyzer looks at the references to detect the version of FHIR used.
  • Elements in the C# classes get a "starting versions" attribute to guide the analyzer.
  • The analyzer will be packages as a separate NuGet Package.
  • Next real steps: start by isolating Base, Any, IExtensible(sp?), and have a separate project just to see what we encounter in practice.

Web.Api

  • It's hard to make it work across Framework/Core because ASP.NET uses a different dependency injection frameowkr.
  • Brian has a solution that he does not like at all, will try again and would like to show us next time.
  • Brian is proposing to name the two flavours of the WebApi Hl7.Fhir.NetCoreApi.STU3 and Hl7.Fhir.WebApi.STU3, the common sets is Hl7.Fhir.WebApi.Models [-> rename to .Support].

Action items

  • George will commit the code for the analyzer
  • George/Ewout will start to split off common code "for real"
  • We will discuss sunsetting DSTU2 during US call
  • Brian will do an experimental run on code generation of an "unknown code" in all enums.
  • Brian has pulled out the Web.Api stuff from the repo to new repo https://github.com/brianpos/fhir-net-web-api, just needs to be removed from the API repo.
  • Luke will try to see if the PR for the new FhirClient is doable in 4.x. Probably did this - will see if he wants to report on it next time.
  • Brian/Kenneth to set up a targeted meeting to discuss these different interfaces for WebApi. Ewout to send contact details of interested parties (Vonk, MS, Kenneth, BrianP, Mottini).
  • Ewout to schedule a meeting to show proposed changes to the internals of the validator [DELAYED until further notice]
  • Brian to show us the Web.Api injection problem next time.
Clone this wiki locally