Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2930 Clean up IsNested/BackboneType attribute information #2939

Merged
merged 25 commits into from
Oct 23, 2024
Merged

2930 Clean up IsNested/BackboneType attribute information #2939

merged 25 commits into from
Oct 23, 2024

Conversation

ewoutkramer
Copy link
Member

@ewoutkramer ewoutkramer commented Oct 18, 2024 •
edited by Kasdejong
Loading

Fixes #2930.

  • I removed the old IsResource attribute parameter, since that is not necessary anymore, resources will always be derived from Resource.
  • I changed FhirType.IsNestedType to FhirType.IsBackboneType to align with common terminology.
  • I changed the name of the FhirType to be the definition path of the BackboneElement, since that is generally considered to be its name. This also means we don't need a separate BackboneTypeAttribute(.DefinitionPath) anymore.

⚠️ This removes IsResource from the FhirTypeAttribute. One can just check against the Resource subtype instead.
⚠️ This renames the IsNestedType parameter on FhirTypeAttribute to IsBackboneType.
⚠️ This removes the BackboneTypeAttribute class. Check IsBackboneType, the type's name is the definition path.
⚠️ The DefinitionPath property of ClassMapping is now gone, since it is the same as the ClassMapping.Name for backbone types.

Kas: Also changed the signature of an evaluation context method, which seemed like the right thing to do to fix a failing unit test.

richfirely and others added 8 commits October 14, 2024 17:11
@richfirely
Update Parameters.cs
825fef0 
Minor doc fix on Parameters Get operations.
@ewoutkramer
Merge pull request #2912 from FirelyTeam/fix/parameters-get-doc-fix
f257ab2 
Update Parameters.cs for Get from remove to retrieve
@whyfate
Remove the Charset from the Accept Header and replace it with the Acc…
c173712 
…ept-Charset Header.
@whyfate
update compatibility suppressions file.
b4b27c9
@whyfate
fix:unittest.
c75aab7
@ewoutkramer
Merge pull request #2922 from whyfate/improve-restapi-accept-header
37fe281 
Remove the Charset from the Accept Header and replace it with the Accept-Charset Header.
@ewoutkramer
Removed IsResource/IsNestedType.
193d73d 
Also fixed some obsolete warnings that no one seems to care about.
@ewoutkramer
Binary changes.
3c7459d
@ewoutkramer ewoutkramer requested a review from Kasdejong October 18, 2024 15:09
This was referenced Oct 18, 2024
Closed
Merged
@ewoutkramer ewoutkramer changed the base branch from develop to develop-6.0 October 18, 2024 15:16
@ewoutkramer
Copy link
Member Author

Review FirelyTeam/fhir-codegen#43 too.

@ewoutkramer ewoutkramer marked this pull request as draft October 18, 2024 15:20
@ewoutkramer ewoutkramer marked this pull request as ready for review October 18, 2024 15:53
@ewoutkramer ewoutkramer changed the title 2930 Remove IsNested type 2930 Clean up IsNested/BackboneType attribute information Oct 18, 2024
@Kasdejong
changed SSG setting usage
f2afb0b
@Kasdejong
this should make the tests run!
807d161
@Kasdejong
Changed the behaviour of force-regenerate to be more in line with the…
e884814 
… old behaviour. There is still a key difference in root elementDef handling
@Kasdejong
Changed the behaviour of force-regenerate to be more in line with the…
5c1468e 
… old behaviour. There is still a key difference in root elementDef handling
@Kasdejong
Merge remote-tracking branch 'origin/feature/use-proper-snapshot-gene…
0bb438a 
…ration-settings' into feature/use-proper-snapshot-generation-settings

# Conflicts:
#	src/Hl7.Fhir.Conformance/Specification/Snapshot/SnapshotGenerator.cs
#	src/Hl7.Fhir.STU3/Specification/Snapshot/SnapshotGenerator.cs
@Kasdejong
ForceRegenerate should now ACTUALLY force regeneration. Naturally, th…
9522fb3 
…is should not be used.
@Kasdejong
Forgot to align this with the Specification SSG
75925ef
@Kasdejong
Fixed obsoletes
44237fb
@Kasdejong
Merge remote-tracking branch 'origin/6.0/2930-remove-isnested-type' i…
193b791 
…nto 6.0/2930-remove-isnested-type

# Conflicts:
#	src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
@Kasdejong
Merge branch 'feature/use-proper-snapshot-generation-settings' into 6…
6c19042 
….0/2930-remove-isnested-type

# Conflicts:
#	src/Hl7.Fhir.Shared.Tests/Validation/SearchDataExtraction.cs
#	src/Hl7.FhirPath.Tests/Tests/EnviromentTests.cs
@Kasdejong
made "WithResourceOverrides" a static method. I hope this makes more …
81aa4a2 
…sense :)
@Kasdejong
Merge branch 'develop-6.0' into 6.0/2930-remove-isnested-type
d478750 
# Conflicts:
#	src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
@Kasdejong
compatibility suppressions
8f12cdc
ewoutkramer and others added 3 commits October 22, 2024 17:30
@ewoutkramer
Small fix to unit test, since the name of backbones has changed.
5479d86
@Kasdejong
Merge branch 'develop-6.0' into 6.0/2930-remove-isnested-type
ab691a1 
# Conflicts:
#	src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
#	src/Hl7.Fhir.Base/FhirPath/FhirEvaluationContext.cs
#	src/Hl7.FhirPath.R4.Tests/PocoTests/FhirPathTest.cs
@Kasdejong
updated CompatibilitySuppressions.xml
be68c7b
@Kasdejong Kasdejong merged commit f530fdd into develop-6.0 Oct 23, 2024
14 checks passed
@Kasdejong Kasdejong deleted the 6.0/2930-remove-isnested-type branch October 23, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kasdejong Kasdejong Kasdejong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove IsNested property from the FhirTypeAttribute
4 participants
@ewoutkramer @Kasdejong @richfirely @whyfate