#2661 FhirClient Serialization engine modification #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss. Made the FhirClient read directly from settings instead, allowing the serialization engine to be changed on the fly.
mmsmits
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The serialization engine used by an instance of BaseFhirClient (or its derivations) can now be changed in the settings. The new value will decide the engine used by this client. This used to require a new client with the required serialization engine in the constructor.
Related issues
Closes issue #2661.
Testing
Added a unit test which tests whether the serialization engine used by BaseFhirClient matches an expected type