Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing returns to SourceNodeComparator #2648

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Add missing returns to SourceNodeComparator #2648

merged 1 commit into from
Jan 3, 2024

Conversation

mmsmits
Copy link
Member

@mmsmits mmsmits commented Jan 2, 2024

fixes: #2647

@mmsmits mmsmits enabled auto-merge January 2, 2024 16:37
@mmsmits mmsmits merged commit ef4ab78 into develop Jan 3, 2024
15 checks passed
@mmsmits mmsmits deleted the bugfix/2647-source-node-comparer-is-missing-returns branch January 3, 2024 08:32
p-liubchenko
p-liubchenko suggested changes Jan 3, 2024
View reviewed changes
Copy link

@p-liubchenko p-liubchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 20 still missing return

@marcovisserFurore
Copy link
Member

Line 20 still missing return

Well spotted Paul!

@p-liubchenko
Copy link

also please consider adding tests for each fail case so we will never get back to this again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-liubchenko p-liubchenko p-liubchenko requested changes

@marcovisserFurore marcovisserFurore marcovisserFurore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SourceNodeComparator is missing returns.
3 participants
@mmsmits @marcovisserFurore @p-liubchenko