Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SourceNodeComparator is missing returns. #2647

Closed
mmsmits opened this issue Jan 2, 2024 · 1 comment · Fixed by #2648 or #2649
Closed

SourceNodeComparator is missing returns. #2647

mmsmits opened this issue Jan 2, 2024 · 1 comment · Fixed by #2648 or #2649
Assignees
@mmsmits

Comments

@mmsmits
Copy link
Member

mmsmits commented Jan 2, 2024

SourceNodeComparator sometimes calls TreeComparisonResult.Fail(actual.Location, $"number of children was different");, but then just continues, instead of returning the results.

This results in false positive outcomes.
@mmsmits mmsmits self-assigned this Jan 2, 2024
@mmsmits mmsmits added the bug label Jan 2, 2024
@mmsmits mmsmits mentioned this issue Jan 2, 2024
Merged
@mmsmits mmsmits mentioned this issue Jan 3, 2024
Merged
@ewoutkramer
Copy link
Member

oops ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmsmits mmsmits

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ewoutkramer @mmsmits