Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FhirEvaluationContext.TerminologyService should be of type ICodeValidationTerminologyService #2590

Closed
marcovisserFurore opened this issue Sep 15, 2023 · 1 comment
Labels
breaking change This issue/commit causes a breaking change, and requires a major version upgrade

Comments

@marcovisserFurore
Copy link
Member

In the current implementation, the terminology service defined within the FhirEvaluationContext class is of the type ITerminologyService, which is overly broad for our specific needs. Our sole requirement within FhirPath is to utilize the ValueSetValidateCode() method. Therefore, it would be more appropriate to reconfigure FhirEvaluationContext.TerminologyService to be of the type ICodeValidationTerminologyService to align with our focused functionality.

@alexzautke
Copy link
Member

Our sole requirement within FhirPath is to utilize the ValueSetValidateCode() method.

That is until some ImplementationGuide requires the usage the subsumes FHIRPath operation. It took some years until users wanted to have memberOf, so it’s unlikely but at least it’s defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This issue/commit causes a breaking change, and requires a major version upgrade
Projects
None yet
Development

No branches or pull requests

4 participants