Skip to content

Commit

Permalink
Removed a specific test - why is Matches(null) always false? I think …
Browse files Browse the repository at this point in the history
…it should be true.
  • Loading branch information
ewoutkramer committed Dec 5, 2024
1 parent 0b530e7 commit 6596bbf
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,8 @@ public void TestMatchAndExactly(ZipArchiveEntry entry)
"Serialization of " + name + " did not match output - Matches test");
Assert.IsTrue(resource.IsExactly(r2),
"Serialization of " + name + " did not match output - IsExactly test");
Assert.IsFalse(resource.Matches(null), "Serialization of " + name + " matched null - Matches test");
//EK 2024-12-05: Removed this test as I think the logic of matches is that anything matches the null pattern.
//Assert.IsFalse(resource.Matches(null), "Serialization of " + name + " matched null - Matches test");
Assert.IsFalse(resource.IsExactly(null),
"Serialization of " + name + " matched null - IsExactly test");
}
Expand Down

0 comments on commit 6596bbf

Please sign in to comment.