Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

575 Investigate static libraries on 2.0 #549

Closed
wants to merge 18 commits into from

Conversation

baseTwo
Copy link
Collaborator

@baseTwo baseTwo commented Sep 17, 2024

Work for

This PR is to look at the applied changes the PR below and the effect it has on the generated C# libraries. These libraries are all static now. Will be discussed internally before accepting.

Additional changes applied from the PR:

  • Make libraries non-static
  • Inject library dependencies via primary constructor
  • Add extensions to build libraries on IServiceCollection

@baseTwo baseTwo changed the base branch from 409-update-20-documentation to 262-refactor---rename-nameandversionlibrarykey-to-versionedidentifer September 17, 2024 13:48
@baseTwo baseTwo changed the base branch from 262-refactor---rename-nameandversionlibrarykey-to-versionedidentifer to 409-update-20-documentation September 17, 2024 13:49
@baseTwo baseTwo linked an issue Sep 17, 2024 that may be closed by this pull request
@baseTwo baseTwo changed the title Temp 1.0 static libs 511 Investigate static libraries on 2.0 Sep 17, 2024
@baseTwo baseTwo changed the title 511 Investigate static libraries on 2.0 575 Investigate static libraries on 2.0 Sep 25, 2024
@baseTwo baseTwo linked an issue Sep 25, 2024 that may be closed by this pull request
@baseTwo
Copy link
Collaborator Author

baseTwo commented Oct 3, 2024

This was a conceptual PR. The 1.0 implementation is to use singleton libraries, so it would be best to get 2.0 consistent with the current 1.0 implementation

@baseTwo baseTwo closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance hit with numerous class initializations (2.0)
2 participants