Skip to content

fix: callbacks not firing in React 18+ with StrictMode#11

Merged
turnervink-finch merged 3 commits intomainfrom
turner/conn-3440-fix-broken-callbacks
Jan 23, 2026
Merged

fix: callbacks not firing in React 18+ with StrictMode#11
turnervink-finch merged 3 commits intomainfrom
turner/conn-3440-fix-broken-callbacks

Conversation

@turnervink-finch
Copy link
Copy Markdown
Contributor

Attention external contributors!

Pull requests in this repo are not routinely reviewed. Do not submit pull requests if you are having issues with Finch Connect. Instead please reach out to our support team at developers@tryfinch.com.

What is changing?

What does this pull request change?

  • Fixes an issue where callbacks were not fired when using React 18+ with StrictMode enabled

⚠️ What breaking changes will developers need to handle?

Do any of the changes require users of the SDK to handle breaking changes when they update to the new version?

No

Why is it changing?

What is the reason behind these changes? What problems do they solve, or what features do they add?

Addresses a bug that breaks core functionality for users of React 18+ with StrictMode

Relevant resources

Please link to any related issues, pull requests, etc. that offer context to this change

What steps did you take to test this?

Please detail the steps you have taken to validate that the proposed changes function as expected, and that existing functionality is not broken by the proposed changes.

This can include manual testing with proof of results, as well as detailing automated testing that was added or modified.

Verified manually using the example React app that the model could not be closed before this fix, but can be after it.

Screenshots

Include screenshots to back up the results of the testing detailed above

n/a

Was the relevant documentation updated?

Is there any documentation that requires updates along with these changes?

n/a

Copy link
Copy Markdown

@vprado-dev vprado-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@turnervink-finch turnervink-finch marked this pull request as ready for review January 23, 2026 18:26
@turnervink-finch turnervink-finch requested a review from a team as a code owner January 23, 2026 18:26
@turnervink-finch turnervink-finch merged commit e164fba into main Jan 23, 2026
@turnervink-finch turnervink-finch deleted the turner/conn-3440-fix-broken-callbacks branch January 23, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants