Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Preserve annotations when adjusting index (#829) #832

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Preserve annotations when adjusting index (#829) #832

wants to merge 2 commits into from

Conversation

fbjerggaard
Copy link

Fixes #829

@fbjerggaard
Copy link
Author

@dotnet-policy-service agree

AndrewTriesToCode
AndrewTriesToCode requested changes Jun 7, 2024
View reviewed changes
Copy link
Sponsor Contributor

@AndrewTriesToCode AndrewTriesToCode left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add similar annotation copying down in AdjustKey prior to the removal of the pre-existing key?

@fbjerggaard
Copy link
Author

I knew I forgot something - should be all done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewTriesToCode AndrewTriesToCode Awaiting requested review from AndrewTriesToCode

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotations not preserved with adjustindexes [NPGSQL]
2 participants
@fbjerggaard @AndrewTriesToCode