Update dependencies #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated o-overlay mixins have been added verbatim: the latest version of oOverlay isn't compatible with implementations that attempted to recreate behaviour component-by-component. 🐿 v2.12.5
edds
reviewed
Nov 26, 2019
src/scss/main.scss
Outdated
| @import "o-overlay/main"; | ||
| @import "o-visual-effects/main"; | ||
|
|
||
| $system-code: "n-syndication"; |
There was a problem hiding this comment.
We shouldn't be setting the system code in components, only in systems. If this is needed for demos/testing it should be put into a stylesheet used for that purpose.
There was a problem hiding this comment.
Added to ./test/main.scss
i-like-robots
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated o-overlay mixins have been added verbatim: the latest
version of oOverlay isn't compatible with implementations that attempted
to recreate behaviour component-by-component.
WIP while
n-ui-foundationsis being upgraded🐿 v2.12.5