only include isomorphic-fetch if the application has explicitly disabled native fetch

[apaleslimghost]

this will allow us to gradually enable native fetch in apps without a breaking change. by default, apps on Node 18 using Tool Kit set this flag. once everything has migrated to native fetch we can remove the dependency on isomorphic-fetch.

[ivomurrell]

nitpick: not that we support said versions anymore, but process.allowedNodeEnvironmentFlags.has('--no-experimental-fetch') resolving to false implies that this is an older Node version without support for native fetch so we should fallback to isomorphic-fetch in that case

Suggested change

	process.allowedNodeEnvironmentFlags.has('--no-experimental-fetch') &&
	process.execArgv.includes('--no-experimental-fetch')
	!process.allowedNodeEnvironmentFlags.has('--no-experimental-fetch') ||
	process.execArgv.includes('--no-experimental-fetch')

[apaleslimghost]

oh very good point

[ivomurrell]

suggestion: could we expand this comment to add a bit of context on why we're doing this? afaict it's to satisfy problem hub as there won't be any behavioural change (as isomorphic-fetch already checks if native fetch is present)

[apaleslimghost]

so this idea is from Jen's original native fetch investigation. which i should have read a bit closer, because the reason she's suggesting doing it this way is so we can add a warning here. i'll do that. maybe?

[rowanmanning]

This looks like prettier or something edited an unrelated bit of code. The config seems wrong because ESLint is complaining about double quotes.

[ivomurrell]

bike shedding territory:

• i think it's fine to include a prettier change in an unrelated commit, nbd imo
• eslint is wrong in this case, prettier chooses double quotes here because it's more readable and eslint shouldn't be complaining about that. should probably be using the eslint prettier plugin to avoid these conflicts.