Skip to content

Commit

Permalink
Removed GO111MODULE env var and Updated Lint version (#41)
Browse files Browse the repository at this point in the history
* Update versions of golangci-lint and go itself.

* Removed GO111MODULE env var

* fixup! Update versions of golangci-lint and go itself.

* fixup! fixup! Update versions of golangci-lint and go itself.

* fixup! fixup! fixup! Update versions of golangci-lint and go itself.

---------

Co-authored-by: Todor Videv <[email protected]>
  • Loading branch information
ilian2233 and Todor Videv authored Feb 13, 2024
1 parent ff4bb1c commit d70b49d
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 6 deletions.
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ ENV PROJECT=orb-integration-tests
COPY . "/${PROJECT}"
WORKDIR "/${PROJECT}"

RUN go mod download
RUN go build -mod=readonly -a -o /artifacts/${PROJECT}

# Multi-stage build - copy certs and the binary into the image
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module github.com/Financial-Times/golang-ci-orb

go 1.13
go 1.21
2 changes: 1 addition & 1 deletion src/commands/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ description: Runs golangci-lint toool with predefined linters' config
parameters:
golangci-lint-version:
type: string
default: "v1.51.1"
default: "v1.56.1"
golangci-config:
description: >
Location for golangci config file to be used (downloaded with wget)
Expand Down
6 changes: 3 additions & 3 deletions src/commands/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ steps:
- run:
name: Download goveralls
command: |
GO111MODULE=off go get github.com/mattn/goveralls
go get github.com/mattn/goveralls
- run:
name: Download go-junit-report
name: Install goveralls
command: |
GO111MODULE=off go get -u github.com/jstemmer/go-junit-report
go install github.com/mattn/goveralls
- run:
name: Create test folders
command: |
Expand Down
2 changes: 1 addition & 1 deletion src/jobs/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ parameters:
default: default
golangci-lint-version:
type: string
default: "v1.51.1"
default: "v1.56.1"
golangci-config:
description: >
Location for golangci config file to be used (downloaded with wget)
Expand Down
1 change: 1 addition & 0 deletions src/scripts/build-source.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
git config --global --unset url."ssh://[email protected]".insteadOf
export GOPRIVATE="github.com/Financial-Times"
git config --global url."https://${GITHUB_USERNAME}:${GITHUB_TOKEN}@github.com".insteadOf "https://github.com"
go mod download
go build -mod=readonly -v ./...

0 comments on commit d70b49d

Please sign in to comment.