Merge pull request #35 from Financial-Times/fix/UPPSF-4330-linter-conf

Move linters config file to the orb repository

.circleci/config.yml

@@ -47,4 +47,4 @@ workflows:
           context: cm-team-orb-publishing
           requires:
             - publish-dev
-          filters: *only_branches
+          filters: *tags_and_branches

src/commands/lint.yml

@@ -7,13 +7,24 @@ parameters:
     description: >
       Location for golangci config file to be used (downloaded with wget)
     type: string
-    default:
-      "https://raw.githubusercontent.com/Financial-Times/upp-coding-standard/\
-      v1.3.2/golangci-config/.golangci.yml"
+    default: ""
 steps:
-  - run:
-      name: Download linters' config file
-      command: wget <<parameters.golangci-config>>
+  - when:
+      condition: <<parameters.golangci-config>>
+      steps:
+        - run:
+            name: Download linters' config file if given as parameter
+            command: wget -O .golangci.yml <<parameters.golangci-config>>
+  - unless:
+      condition: <<parameters.golangci-config>>
+      steps:
+        - run:
+            name: >
+              Copy linters' config file from orb source code into
+              the job executor’s filesystem
+            environment:
+              CONFIG_CONTENT: <<include(conf/.golangci.yml)>>
+            command: /bin/echo "$CONFIG_CONTENT" > .golangci.yml
   - run:
       name: Run linters
       environment:

src/conf/.golangci.yml

@@ -0,0 +1,54 @@
+linters-settings:
+  govet:
+    check-shadowing: true
+    settings:
+    printf:
+    funcs:
+      - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof
+      - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf
+      - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
+      - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
+  revive:
+    confidence: 0
+  gocognit:
+    min-complexity: 20
+
+linters:
+  disable-all: true
+  enable:
+    - bodyclose
+    - errcheck
+    - gocognit
+    - gofmt
+    - goimports
+    - gosec
+    - gosimple
+    - govet
+    - ineffassign
+    - misspell
+    - revive
+    - staticcheck
+    - stylecheck
+    - typecheck
+    - unparam
+    - unused
+    - whitespace
+
+run:
+  skip-dirs:
+    - test/testdata_etc
+    - pkg/golinters/goanalysis/(checker|passes)
+
+issues:
+  exclude-rules:
+    - text: "weak cryptographic primitive"
+      linters:
+        - gosec
+
+# golangci.com configuration
+# https://github.com/golangci/golangci/wiki/Configuration
+service:
+  # use the fixed version to not introduce new linters unexpectedly
+  golangci-lint-version: 1.17.x
+  prepare:
+    - echo "here I can run custom commands"

src/jobs/build-and-test.yml

@@ -16,9 +16,7 @@ parameters:
     description: >
       Location for golangci config file to be used (downloaded with wget)
     type: string
-    default:
-      "https://raw.githubusercontent.com/Financial-Times/upp-coding-standard/\
-      v1.3.2/golangci-config/.golangci.yml"
+    default: ""
   coverage-report-folder:
     description: Folder to temporarily store coverage results
     type: string