Skip to content

Conversation

@hervyt
Copy link
Member

@hervyt hervyt commented Sep 22, 2025

Context

Briefly describe the purpose and context of this PR. Include relevant screenshots or screen recordings for the product team.

How to test

Provide step-by-step instructions to test your changes. Include screenshots of your local testing results.

Related issues

  • Related to #issueNumber

Checklist

Quality

  • I consider this work complete and ready for review
  • I tested all features and edge cases
  • I refactored code where necessary to improve quality
  • I made sure my code meets development guidelines
  • I performed a self-review of my code

Testing

  • I wrote test cases for the relevant use cases (unit, integration or e2e tests)
  • (Bug fixes only) I added tests that reproduce and verify the fix

What tests have been made

  • Unit tests
  • Integration tests
  • E2E tests
  • Local manual tests

Additional information

Any additional context, dependencies, or concerns reviewers should know about.

@hervyt hervyt marked this pull request as draft September 22, 2025 12:14
@github-actions github-actions bot added the Filigran Team use to identify PR from the Filigran team label Sep 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
22 22 0 0 0 0 2m 19s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
22 0 0 22.6s

Suites

22 passed, 0 failed, and 0 other

Suite Passed Failed Other Duration
✅ app/apps/portal-e2e-tests/tests/tests_files/api/user.spec.ts
        ✅ should prevent user to update another one when he does not have MANAGE_ACCESS
        ✅ should allow user to update another one when he has ADMINISTRATE_ORGANIZATION
        ✅ should allow user to update another one when he has MANAGE_ACCESS
✅ 3 ❌ 0 ⏭️ 0 4.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/capabilities.spec.ts
        ✅ Should add subscription with capabilities
✅ 1 ❌ 0 ⏭️ 0 22.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/csv-feeds.spec.ts
        ✅ Should add CSV Feed
        ✅ Should delete CSV Feed from the list
        ✅ Should delete CSV Feed from the detailed page
✅ 3 ❌ 0 ⏭️ 0 22.3s
✅ app/apps/portal-e2e-tests/tests/tests_files/custom-dashboards.spec.ts
        ✅ Should add custom dashboard
        ✅ Should see the custom dashboard on public page
        ✅ Should edit a custom dashboard
✅ 3 ❌ 0 ⏭️ 0 27.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/document.spec.ts
        ✅ should perform complete CRUD operations on documents
✅ 1 ❌ 0 ⏭️ 0 4.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/one-click-deploy.spec.ts
        ✅ should send telemetry event
✅ 1 ❌ 0 ⏭️ 0 6.3s
✅ app/apps/portal-e2e-tests/tests/tests_files/organizations.spec.ts
        ✅ should perform complete CRUD operations on organizations
✅ 1 ❌ 0 ⏭️ 0 5.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/profile.spec.ts
        ✅ should update user profile information
✅ 1 ❌ 0 ⏭️ 0 4.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/public/redirections.spec.ts
        ✅ should redirect user between public pages and login page
✅ 1 ❌ 0 ⏭️ 0 3.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/registration.spec.ts
        ✅ should register openAEV platform
        ✅ should register openCTI platform
✅ 2 ❌ 0 ⏭️ 0 6.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-management.spec.ts
        ✅ should be able to admin service
✅ 1 ❌ 0 ⏭️ 0 9.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-pictures.spec.ts
        ✅ should be able to add pictures to a service
✅ 1 ❌ 0 ⏭️ 0 4.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/user.spec.ts
        ✅ Should perform complete CRUD of users as BYPASS
        ✅ Should only see authorized users
        ✅ Should not edit first and last name as MANAGE_ACCESS user
✅ 3 ❌ 0 ⏭️ 0 16.4s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@hervyt hervyt force-pushed the tech/nx-improvments-second branch from c1bc790 to c4b242c Compare September 22, 2025 13:48
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.42%. Comparing base (da13114) to head (ddcf9cb).
⚠️ Report is 4 commits behind head on development.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #985      +/-   ##
===============================================
+ Coverage        20.35%   20.42%   +0.07%     
===============================================
  Files              488      492       +4     
  Lines            28152    28431     +279     
  Branches          1029     1038       +9     
===============================================
+ Hits              5729     5808      +79     
- Misses           22193    22392     +199     
- Partials           230      231       +1     

see 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da13114...ddcf9cb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hervyt hervyt force-pushed the tech/nx-improvments-second branch 14 times, most recently from b766f16 to 58d1894 Compare September 23, 2025 12:05
@hervyt hervyt force-pushed the tech/nx-improvments-second branch 4 times, most recently from 8b92f88 to f374fb1 Compare September 23, 2025 12:38
@hervyt hervyt force-pushed the tech/nx-improvments-second branch 6 times, most recently from 49ece97 to e4b0f10 Compare September 23, 2025 13:21
@hervyt hervyt force-pushed the tech/nx-improvments-second branch from e4b0f10 to 31f3200 Compare September 23, 2025 13:26
@hervyt hervyt force-pushed the tech/nx-improvments-second branch 7 times, most recently from bb8381b to 1c965d0 Compare September 24, 2025 08:34
@hervyt hervyt force-pushed the tech/nx-improvments-second branch from 1c965d0 to ddcf9cb Compare September 24, 2025 08:41
@jbanety jbanety force-pushed the development branch 2 times, most recently from 1abcd8f to c5ee434 Compare October 17, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Filigran Team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants