-
Notifications
You must be signed in to change notification settings - Fork 1
feat: standardise SP approval review tracking with issue template #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TippyFlitsUK
wants to merge
1
commit into
FilOzone:master
Choose a base branch
from
TippyFlitsUK:TippyFlitsUK-sp-approval-template
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| --- | ||
| name: SP Approval Review | ||
| about: Track a Storage Provider (SP) approval review and decision | ||
| title: "[SP Approval Review] f0xxxx" | ||
| labels: ["sp-approval-review"] | ||
| assignees: [] | ||
|
rjan90 marked this conversation as resolved.
|
||
| --- | ||
|
|
||
| ## SP Approval Review | ||
|
|
||
| ### SP Details | ||
| - **SP ID:** | ||
| - **SP Name (optional):** | ||
|
|
||
| --- | ||
|
|
||
| ### Review Trigger | ||
| - **Time review started (UTC):** | ||
| - **Trigger condition:** | ||
| <!-- e.g. Storage success <97%, Retrieval failures, Retention faults --> | ||
|
|
||
| --- | ||
|
|
||
| ### Metrics | ||
|
|
||
| **Failing metric(s):** | ||
| - | ||
|
|
||
| **Observed value(s):** | ||
| - | ||
|
|
||
| **Threshold(s):** | ||
| - | ||
|
|
||
| --- | ||
|
|
||
| ### Investigation Window | ||
| - **Investigation deadline (UTC):** | ||
| - **Within maintenance window?** Yes / No | ||
|
|
||
| --- | ||
|
|
||
| ### Communication | ||
|
|
||
| - **SP notified?** Yes / No | ||
| - **Channel used:** | ||
| <!-- #pdp-endorsed-sp OR #fil-pdp-mainnet-launch --> | ||
|
|
||
| - **SP response (if any):** | ||
| <!-- brief summary --> | ||
|
|
||
| --- | ||
|
|
||
| ### Diagnosis | ||
|
|
||
| **Current assessment:** | ||
| - [ ] SP-side issue | ||
| - [ ] Dealbot / tooling issue | ||
| - [ ] Network / external issue | ||
| - [ ] Unknown | ||
|
|
||
| **Notes:** | ||
| <!-- What do we think is happening? --> | ||
|
|
||
| --- | ||
|
|
||
| ### Outcome | ||
|
|
||
| - [ ] Recovered within investigation window | ||
| - [ ] Unapproved | ||
|
|
||
| - **Decision time (UTC):** | ||
|
|
||
| --- | ||
|
|
||
| ### Actions Taken | ||
|
|
||
| - [ ] SP remained approved | ||
| - [ ] SP unapproved | ||
| - [ ] Follow-up issue created | ||
| - [ ] Escalated | ||
|
|
||
| --- | ||
|
|
||
| ### Links & Evidence | ||
|
|
||
| - Dashboard (spdash): | ||
| - Dealbot runs: | ||
| - Logs / errors: | ||
| - Related issues: | ||
|
|
||
| --- | ||
|
|
||
| ### Notes | ||
|
|
||
| <!-- Anything else useful for future reference --> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.