fix(deploy): pass new PDPVerifier constructor args in warm-storage-deploy-all.sh#472
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Warm Storage “deploy all” tooling to support a newer PDPVerifier constructor by ensuring required constructor arguments (including the FilecoinPayV1 address and USDFC sybil fee) are provided during deployment.
Changes:
- Adds
PDP_USDFC_SYBIL_FEEenv var (defaulting to 0.1 USDFC in attoUSDFC) forPDPVerifierconstructor usage. - Reorders deployment steps to deploy
FilecoinPayV1beforePDPVerifier, and passes the newPDPVerifierconstructor args. - Documents the new optional env var in the tools README.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| service_contracts/tools/warm-storage-deploy-all.sh | Adds PDP_USDFC_SYBIL_FEE, deploys FilecoinPayV1 earlier, and passes new PDPVerifier constructor args. |
| service_contracts/tools/README.md | Documents PDP_USDFC_SYBIL_FEE for warm-storage-deploy-all.sh. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-project-automation
Bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came up in FilOzone/foc-devnet#107