-
Notifications
You must be signed in to change notification settings - Fork 14
chore: prep v0.2.0 changelog #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes since commit e24ce37, which is when the entry for v0.1.0 was created in the changelog. From now on we will tag releases, so that finding the diff will be easier. Items below marked with ✅ has been highlighted in the changelog: git log --oneline e24ce37..main
|
Just commenting here that a lot of the oldest changes from the diff between 0.1.0 and 0.2.0 in the tags are kind of outdated, as there have been multiple contracts/releases published: https://github.com/FilOzone/filecoin-services/tags, but we have not kept a good enough changelog on them. |
e922400
to
c047dad
Compare
c096105
to
550eb03
Compare
Okay, deploying the M3 Filecoin Warm Storage Service contract for Calibration from this commit:
I´m using the https://github.com/FilOzone/filecoin-services/blob/main/service_contracts/tools/deploy-warm-storage-calibnet.sh script, and are setting these env-vars:
Running the script gives:
|
The https://github.com/FilOzone/filecoin-services/blob/main/service_contracts/tools/deploy-warm-storage-calibnet.sh is missing publishing the Ideally we should just consolidate all these scripts into the |
4eff78e
to
2705010
Compare
docs: add #260 to the changelog after rebase
docs: update date in 0.2.0 release
docs: update new FWSS M3 addresses
Round 2 of deploying the M3 Filecoin Warm Storage Service contracts to CalibnetNow with the
Env-var set:
Script output:
Updated the addresses in: 7675357 |
I have successfully verified: 1. FilecoinWarmStorageService Implementation
2. FilecoinWarmStorageServiceStateView
Struggling with getting Verification Commands Used# Successfully verified Implementation
filfox-verifier forge --chain 314159 \
0x2d76e3A41fa4614D1840CEB73aa07c5d0af6a023 \
src/FilecoinWarmStorageService.sol:FilecoinWarmStorageService
# Successfully verified StateView
filfox-verifier forge --chain 314159 \
0x7175a72479e2B0050ed310f1a49a517C03573547 \
src/FilecoinWarmStorageServiceStateView.sol:FilecoinWarmStorageServiceStateView |
The Working Solution# 1. Flatten the contract using forge
cd service_contracts
forge flatten lib/pdp/src/ERC1967Proxy.sol --output /tmp/MyERC1967ProxyFlat.sol
# 2. Copy to src directory with a clean name
cp /tmp/MyERC1967ProxyFlat.sol src/MyERC1967ProxyFlat.sol
# 3. Verify using filfox-verifier with the clean src path
filfox-verifier forge --chain 314159 \
0x9ef4cAb0aD0D19b8Df28791Df80b29bC784bE91b \
src/MyERC1967ProxyFlat.sol:MyERC1967Proxy
# 4. Clean up
rm src/MyERC1967ProxyFlat.sol FilecoinWarmStorageService Proxy (MyERC1967Proxy)
|
Towards: #254
Although currently blocked on pushing releases until FilOzone/pdp#210 is out, a initial review of the changelog at this point seems like a good starting point