Skip to content

Conversation

jennijuju
Copy link
Collaborator

resolves: #229

following https://github.com/OpenZeppelin/openzeppelin-contracts/tree/master

should archive the other repos once this is merged

@FilOzzy FilOzzy added this to FS Oct 2, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FS Oct 2, 2025
@jennijuju jennijuju marked this pull request as draft October 2, 2025 17:26
jennijuju and others added 3 commits October 3, 2025 01:43
- Migrate filecoin-pay contracts to src/payments/
- Migrate pdp contracts to src/pdp/
- Migrate SessionKeyRegistry to src/session-key-registry/
- Reorganize existing contracts to src/service-provider/
- Migrate all tests to corresponding test/ subdirectories
- Migrate all deployment/utility scripts to tools/ subdirectories
- Update all import paths to use new remappings
- Add prb-math and pyth-sdk-solidity dependencies
- Remove submodules for migrated contracts
- All 473 tests passing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Resolves conflicts after rebasing onto main by:
- Adding new getProvidersByIds() function to ServiceProviderRegistry
- Adding _getEmptyProviderInfoView() helper function
- Updating getProviderByAddress() to use helper function
- Adding comprehensive tests for getProvidersByIds
- Setting pyth-sdk-solidity to correct commit (11d6bcf)

All tests passing including 6 new tests for getProvidersByIds.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@rvagg
Copy link
Collaborator

rvagg commented Oct 7, 2025

We should aim to ditch the service_contracts directory here and still keep the separate contracts distinct. See #229 for my proposed directory structure for this.

FWIW I reckon Claude would be good at just executing on #229 if it's given that link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📌 Triage
Development

Successfully merging this pull request may close these issues.

Proposal: monorepo & no git submodules
2 participants