Feature: add smart contract verification while deploying #222

DarkLord017 · 2025-09-12T20:04:24Z

Automatic Smart Contract Verification Integration

Resolves #214

This pull request implements automatic smart contract verification across deployment scripts in the service_contracts/tools directory, utilizing the filfox-verifier tool to verify contracts on the Filecoin network. The verification process is controlled via the AUTO_VERIFY environment variable and enhances deployment reliability through automated post-deployment validation.

Changes Made

deploy-all-warm-storage-calibnet.sh: Added comprehensive verification for all major contracts and proxy contracts with automatic dependency installation and chain ID detection
deploy-registry-calibnet.sh: Integrated verification for both registry implementation and proxy contracts
deploy-session-key-registry.sh: Implemented verification for session key registry contract post-deployment
deploy-warm-storage-view.sh: Added verification steps for the state view contract
deploy-warm-storage-implementation-only.sh: Included verification for warm storage implementation contract

Known Issue

Proxy contract verification encounters an import path error with PDP Proxy:

6 | import {ERC1967Proxy} from "../lib/openzeppelin-contracts/contracts/proxy/ERC1967/ERC1967Proxy.sol";

Recommended Fix

Update import statement to use the standardized OpenZeppelin naming convention (@openzeppelin/contracts) to resolve the verification error and ensure compatibility with the filfox-verifier tool.

Pandora Service Contract

Add auth to contract

Feat/service registry mvp

Add `withCDN:bool` to `ProofSetInfo`

All providers getter

feat: add price getter

DarkLord017 · 2025-10-03T23:39:12Z

@wjmelements please review

wjmelements · 2025-10-04T01:03:39Z

Why do you pull the submodules?

service_contracts/tools/verify-contracts.sh

service_contracts/tools/deploy-warm-storage-view.sh

wjmelements · 2025-10-04T01:15:28Z

service_contracts/tools/deploy-registry-calibnet.sh

+
+  pushd "$(dirname $0)/.." >/dev/null
+  source tools/verify-contracts.sh
+  CHAIN_ID=314159 verify_contracts_batch "$REGISTRY_IMPLEMENTATION_ADDRESS,src/ServiceProviderRegistry.sol:ServiceProviderRegistry,ServiceProviderRegistry Implementation"


The rest of this file should also use $CHAIN_ID

wjmelements · 2025-10-04T01:16:11Z

service_contracts/tools/deploy-all-warm-storage.sh

+    pushd "$(dirname "$0")/.." >/dev/null
+    source tools/verify-contracts.sh
+
+    CHAIN_ID=$CHAIN_ID verify_contracts_batch \


I don't think you need CHAIN_ID=$CHAIN_ID.

ah it's not exported. maybe it should be

service_contracts/tools/deploy-session-key-registry.sh

service_contracts/tools/verify-contracts.sh

wjmelements · 2025-10-04T02:37:19Z

For cast args where we are just passing environment variables there are actually ways to use the environment variables more directly. For example

  -r, --rpc-url <URL>
          The RPC endpoint, default value is http://localhost:8545

          [env: ETH_RPC_URL=]

If we called the variable ETH_RPC_URL instead of RPC_URL, we wouldn't need --rpc-url. Another such variable is KEYSTORE. I think there are more.

DarkLord017 · 2025-10-04T15:42:42Z

Why do you pull the submodules?

ya sorry will remove that in next commit

DarkLord017 · 2025-10-04T15:50:07Z

  -r, --rpc-url <URL>
          The RPC endpoint, default value is http://localhost:8545

          [env: ETH_RPC_URL=]
If we called the variable ETH_RPC_URL instead of RPC_URL, we wouldn't need --rpc-url. Another such variable is KEYSTORE. I think there are more.

okay correcting this

) Towards FilOzone#254 We are cutting a set of contracts for the M3 milestone. The price changes in FilOzone#239 was done with FilOzone#250 being landed in mind. Since FilOzone#250 is not going to land before in M4, I have temporarily reverted the price changes, so that we keep the price intact for the M3 contract publishing.

…lOzone#237)

@rvagg

Reviewer @rvagg @Kubuxu Closes FilOzone#257 This should reduce the proof storage growth by a factor of 256. If the proving period is 1 day, and the deal lasts 1 year, this mapping will use 2 slots instead of 356. #### Changes * Change provenPeriods to bitmap

@rvagg

Reviewer @rvagg Per a discussion with @jennijuju, we want to make the upgrade process more transparent. This changes upgrades to a two step process. First, we announce the planned upgrade. Then, after the designated time, we can complete the upgrade. The delay gives us time to check the pending implementation address. It also gives users notice even if we are not in communication with them. I also fix FilOzone#259 in this change, because I was already adding tests for `upgradeToAndCall`. I can fix it separately if this change is rejected. After validating that this is a good design that the team likes, I can replicate it for the other proxies in separate PRs. #### Test Plan I tested the new deployment scripts by running them on calibnet. * [announcePlannedUpgrade](https://calibration.filfox.info/en/message/bafy2bzaceb6vpcsy563vhpwig5g6jy7gb6fr2ssxhjgwiagj7k3vbjrg3dg56?t=3) * [upgradeToAndCall](https://calibration.filfox.info/en/message/bafy2bzaceadjmlemjyrv7nmwh5lzavdbntjmywvblrzmtuh3wsyldqlvxbcyo?t=3) #### Changes * announcePlannedUpgrade * update _authorizeUpgrade * new view method for pending upgrade * make gen * add and fix tests covering upgradeToAndCall with migrate * separate announce and upgrade scripts * update implementation-only script --------- Co-authored-by: Rod Vagg <[email protected]>

wjmelements · 2025-10-07T04:39:30Z

I removed some stuff from deploy-warm-storage-implementation-only so there are merge conflicts. I also make its hardcoded CHAIN_ID into a var/param

Prep v0.2.0 changelog and publish contracts

DarkLord017 · 2025-10-07T23:29:41Z

@wjmelements i am currently making the changes , will let u know once ready for review

DarkLord017 · 2025-10-08T21:48:38Z

@wjmelements please review , i changed according to this

  -r, --rpc-url <URL>
          The RPC endpoint, default value is http://localhost:8545

          [env: ETH_RPC_URL=]
If we called the variable ETH_RPC_URL instead of RPC_URL, we wouldn't need --rpc-url. Another such variable is KEYSTORE. I think there are more.
okay correcting this

DarkLord017 · 2025-10-08T22:13:49Z

please see #272 @wjmelements

jennijuju and others added 30 commits May 21, 2025 20:23

Initial commit

713bd44

pandora service contract

1c27c7c

GH CI

94f3e09

fix CI

43f2959

Merge pull request FilOzone#8 from FilOzone/init/pandora

ac46070

Pandora Service Contract

Update README.md

da1e374

WIP Add auth to contract

cb42444

Contract builds

fe86ff3

Existing tests now work

35f1a6c

Tests for signature validation

c7ed535

Review response

a476796

Merge pull request FilOzone#12 from FilOzone/feat/authenticate-contract

913e1fb

Add auth to contract

service registry

939b696

Review fixups

875774a

Rename total deploy contract

edc39bc

Service contract only deployment

00d8cf1

Merge pull request FilOzone#17 from FilOzone/feat/service-registry-mvp

043699b

Feat/service registry mvp

Remove unused challenge finality

8da8908

Moving files around

e3530d4

All providers getter

34cea23

do not return approved providers

c915fed

add withCDN:bool to ProofSetInfo

e697697

Add withCDN:bool to ProofSetRailCreated

58552e7

docs

a81fc5f

add sign over flag

8cfcf1b

add price getter

6bd25e2

Merge pull request FilOzone#19 from FilOzone/add/cdn-to-proof-set-info

a9d4de9

Add `withCDN:bool` to `ProofSetInfo`

add passing test

99616bf

Merge pull request FilOzone#18 from FilOzone/flip/get-all-providers

dda39e4

All providers getter

Merge pull request FilOzone#23 from FilOzone/feat/getter-for-price

28e2f9f

feat: add price getter

refactor: summary at the end and pass chain id as env

2d1be99

wjmelements reviewed Oct 4, 2025

View reviewed changes

service_contracts/tools/verify-contracts.sh Outdated Show resolved Hide resolved

wjmelements reviewed Oct 4, 2025

View reviewed changes

service_contracts/tools/deploy-warm-storage-view.sh Show resolved Hide resolved

wjmelements reviewed Oct 4, 2025

View reviewed changes

service_contracts/tools/deploy-session-key-registry.sh Outdated Show resolved Hide resolved

wjmelements reviewed Oct 4, 2025

View reviewed changes

service_contracts/tools/verify-contracts.sh Show resolved Hide resolved

rjan90 and others added 4 commits October 6, 2025 08:59

Modify CDN payment rails and add methods for usage-based payments (Fi…

c1ecef0

…lOzone#237)

rjan90 and others added 2 commits October 7, 2025 10:51

chore: prep v0.2.0 changelog (FilOzone#262)

0efd1a9

Prep v0.2.0 changelog and publish contracts

refactor: get from enviorment instead of parsing them in every command

cacc6ae

DarkLord017 added 4 commits October 8, 2025 19:43

directly use env to configure instead of flags

f10b2e7

directly use env to configure instead of flags

e514e97

Merge branch 'main' into main

37c8775

completed the merge

aece2dc

Remove lib/ folder and ignore it

22cb9bf

DarkLord017 closed this Oct 8, 2025

DarkLord017 force-pushed the main branch from 2652450 to 22cb9bf Compare October 8, 2025 21:56

github-project-automation bot moved this from 🔎 Awaiting review to 🎉 Done in FS Oct 8, 2025

Feature: add smart contract verification while deploying #222

Feature: add smart contract verification while deploying #222

Uh oh!

Conversation

DarkLord017 commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automatic Smart Contract Verification Integration

Resolves #214

Changes Made

Known Issue

Recommended Fix

Uh oh!

DarkLord017 commented Oct 3, 2025

Uh oh!

wjmelements commented Oct 4, 2025

Uh oh!

Uh oh!

Uh oh!

wjmelements Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

wjmelements Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

wjmelements Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wjmelements commented Oct 4, 2025

Uh oh!

DarkLord017 commented Oct 4, 2025

Uh oh!

DarkLord017 commented Oct 4, 2025

Uh oh!

wjmelements commented Oct 7, 2025

Uh oh!

DarkLord017 commented Oct 7, 2025

Uh oh!

DarkLord017 commented Oct 8, 2025

Uh oh!

DarkLord017 commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

DarkLord017 commented Sep 12, 2025 •

edited

Loading