-
Notifications
You must be signed in to change notification settings - Fork 14
chore: add FilecoinWarmStorageService dataset metadata schema #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
"version": { | ||
"type": "string", | ||
"pattern": "^\\d+\\.\\d+\\.\\d+$", | ||
"description": "Schema version (semantic versioning)", | ||
"example": "1.0.0" | ||
}, | ||
"created_at": { | ||
"type": "string", | ||
"format": "date-time", | ||
"description": "ISO 8601 creation timestamp" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what would these be useful for?
"ttl": { | ||
"type": "integer", | ||
"minimum": 0, | ||
"default": 0, | ||
"description": "Time-to-live in seconds (0 = no expiry)" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who's consuming this, and what is the user signalling with this?
"description": "Schema version (semantic versioning)", | ||
"example": "1.0.0" | ||
}, | ||
"created_at": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snake_case is is inconsistent here, createdAt
if we really need this, or with_cdn
if we want snake_case
"default": false, | ||
"description": "Get FilCDN add-on" | ||
}, | ||
"IndexIPFSandPublish": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be shorter, also case needs to be consistent; just indexIPFS
might be enough for this
"description": "Index IPFS CIDs and publish to IPNI" | ||
} | ||
}, | ||
"additionalProperties": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"additionalProperties": false | |
"additionalProperties": true |
we should be able to let this be free-form for users, I imagine the only reason we're publishing a schema here is to advertise some standards that we encourage or know get used
"type": "boolean", | ||
"default": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to signal this in jsonschema but I was hoping that these boolean fields would just be omitted for false, and present but empty for true, so we don't waste bytes - key exists, value is ""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, also, this is a string key string value thing, so I'm not sure we can even signal data types other than strings with this anyway
Couple of thoughts:
|
No, we should do something with this; it's more of a TODO than a solid proposal. IMO this ends up more like the multicodec registry - just a table with descriptions of "known metadata". |
add metadata schema for downstream integration
blocked by #131