-
Notifications
You must be signed in to change notification settings - Fork 14
feat: add automated deployment and validation scripts and workflows #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things to resolve before merging this
fi | ||
|
||
# Test 9: PDPVerifier implementation address | ||
if implementation=$(get_proxy_implementation "$PDP_VERIFIER_ADDRESS"); then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These implementation checks are not useful if we remove reporting of implementation addr.
A potentially useful thing is to check that the contract code of the implementation matches the expected. For that you'd
- get the implementation addr from get_proxy_implementation
- check that its code cid matched pdp verifier
feat: add automated deployment and validation scripts and workflows
fix: add address validation and better error handling
chore: update succesful deployment issue text
chore: update schedule
Renames `CALIBNET_KEYSTORE_JSON` to `CALIBNET_KEYSTORE_B64`
fix: update timeout to blocktime
chore: remove no longer valid tests
fix: update deployment parameters
a5a5943
to
638a33c
Compare
Okay, I have rebased this onto the latest changes in main. Will do a quick sanity check in my fork before merging |
Closes #106
Covers some items in #118
Description
This PR adds a workflow for daily deployments of contracts, as well as validation. It is using the pre-funded address here: 0xD1E43422236C921A6172982caFe142F1E9668e52 for deployment of the contracts.
I have added the secrets (
CALIBNET_KEYSTORE_JSON
,CALIBNET_KEYSTORE_PASSWORD
andCALIBNET_RPC_URL
) to the action secrets and variables, so this should be working properly now.The workflow has been tested in my fork here: https://github.com/rjan90/filecoin-services/actions/workflows/scheduled-deployment.yml