Skip to content

Conversation

rjan90
Copy link
Collaborator

@rjan90 rjan90 commented Aug 6, 2025

Closes #106
Covers some items in #118

Description

This PR adds a workflow for daily deployments of contracts, as well as validation. It is using the pre-funded address here: 0xD1E43422236C921A6172982caFe142F1E9668e52 for deployment of the contracts.

I have added the secrets (CALIBNET_KEYSTORE_JSON, CALIBNET_KEYSTORE_PASSWORD and CALIBNET_RPC_URL ) to the action secrets and variables, so this should be working properly now.

The workflow has been tested in my fork here: https://github.com/rjan90/filecoin-services/actions/workflows/scheduled-deployment.yml

@rjan90 rjan90 self-assigned this Aug 6, 2025
@FilOzzy FilOzzy added this to FS Aug 6, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FS Aug 6, 2025
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting review in FS Aug 6, 2025
@rjan90 rjan90 added this to the MX: Priority and sequencing TBD milestone Aug 6, 2025
@rjan90 rjan90 marked this pull request as ready for review August 6, 2025 11:15
Copy link
Collaborator

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things to resolve before merging this

fi

# Test 9: PDPVerifier implementation address
if implementation=$(get_proxy_implementation "$PDP_VERIFIER_ADDRESS"); then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These implementation checks are not useful if we remove reporting of implementation addr.
A potentially useful thing is to check that the contract code of the implementation matches the expected. For that you'd

  1. get the implementation addr from get_proxy_implementation
  2. check that its code cid matched pdp verifier

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FS Aug 7, 2025
rjan90 added 8 commits August 12, 2025 18:50
feat: add automated deployment and validation scripts and workflows
fix: add address validation and better error handling
chore: update succesful deployment issue text
chore: update schedule
Renames `CALIBNET_KEYSTORE_JSON` to `CALIBNET_KEYSTORE_B64`
fix: update timeout to blocktime
chore: remove no longer valid tests
fix: update deployment parameters
@rjan90 rjan90 force-pushed the phi/post-deployment-script branch from a5a5943 to 638a33c Compare August 12, 2025 16:54
@rjan90
Copy link
Collaborator Author

rjan90 commented Aug 12, 2025

Okay, I have rebased this onto the latest changes in main. Will do a quick sanity check in my fork before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✔️ Approved by reviewer

Development

Successfully merging this pull request may close these issues.

Regular contract deployments

2 participants