Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic DegreeSite creation upon Degree entity creation #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sanavarali
Copy link

LRN-20

@@ -72,4 +90,10 @@ public void delete() {
return Stream.of(categoryForSlug("announcement")).filter(Objects::nonNull).map(Category::makeWrap);
}

private CMSFolder folderForPath(MenuContainer parent, String path) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that folders are optional in the CMS, it does not make sense to blow up if that particular folder is not found.

One might want not to organize degree sites in folders (or even set them up in a custom, on different path), so I think it would just be better to do nothing in this case.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, like ExecutionCourseSite example, if parent folder not found, now is created a new one.

JNPA and others added 2 commits April 20, 2015 12:42
@pedrosan7os
Copy link
Contributor

Squash your commits

setCanPostGroup(TeacherResponsibleOfExecutionCourseGroup.get(executionCourse));

setPublished(true);
setBennu(Bennu.getInstance());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line must be back ported to CMS, most likely this doesn't make sense to be made on this place.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which line? You are referring to a whole diff block.
Should be moved where to CMS? Which entity?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Line 70. Attaching the instance to Bennu should be done within the CMS. This is a bug, and should be corrected at CMS. But for now lets leave it here, because this isn't fixed yet on the other module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants