Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback to login button on 404 page | ACDM-1931 #resolve #1807

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add callback to login button on 404 page | ACDM-1931 #resolve #1807

wants to merge 1 commit into from

Conversation

diogotcorreia
Copy link
Contributor

@Luis-Cruz
Copy link
Member

I think there are cases in which this will not work properly.
In some scenarios the URL is not enough no redirect the user (when other context is required to load the page that is lost with the session).
The other case is when the URL contains a checksum. In this case the callback will never work becasuse the checksum dependes on the session which is lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogotcorreia @Luis-Cruz